06-07-2022 11:51 PM - edited 06-07-2022 11:51 PM
06-08-2022 2:18 AM - edited 06-08-2022 2:19 AM
My Entry with a minimal app to pass tests for week1, nothing fancy 🙂
https://github.com/SAP-samples/sap-community-code-challenge-ui5/pull/7
06-08-2022 8:40 AM - edited 06-08-2022 8:40 AM
I also submitted my entry for week1, who can guess what kind of app I am planning to build? Any golf fans out here? ⛳️🏌🏼
https://github.com/SAP-samples/sap-community-code-challenge-ui5/pull/8
06-09-2022 2:56 PM
My pull request is ready after passing all the tests, all in green!
https://github.com/SAP-samples/sap-community-code-challenge-ui5/pull/9
Thanks!
06-10-2022 10:11 AM
New pull request,. Thanks for your suggestions @nicoschoenteich
https://github.com/SAP-samples/sap-community-code-challenge-ui5/pull/11
06-10-2022 2:46 AM
06-10-2022 1:23 PM
06-10-2022 10:59 PM
06-11-2022 6:56 AM
Here is my Pull Request for my very simple ui5 app. 😃
https://github.com/SAP-samples/sap-community-code-challenge-ui5/pull/17
06-20-2022 5:37 AM
Pull request updated for week2 code challenge
06-11-2022 9:01 AM
Hi colleagues! Thanks for the great challenge 👍
Please, find my entry here: https://github.com/SAP-samples/sap-community-code-challenge-ui5/pull/16
06-13-2022 2:09 AM
06-15-2022 4:53 AM
Hi,
We can use the same pull request right?
Is there a way to reduce the output of npm run ci-tests? Loglevel in config did not seem to do much,
As a wish for the next week I would prefer some test cases which are more Fiori Floor Plan oriented. In week 2 the additional Button to navigation is not really best practice if we start with a list 🙂
06-27-2022 1:54 AM
Hi there!
Sorry for the late reply.
Yes, you can use the same PR.
There are two places in the wdio.conf.js where you have to set the logLevel (one global config and one wdi5 specific), make sure you set them both to 'silent'.
Thanks a lot for your suggestions and feedback. You are right, the app we are building here doesn't follow best practices. It was more important to us that it was 'easy to start with' and that people would get familiar with wdi5 in the first place, and I think that was achieved 😉
06-14-2022 5:45 AM
06-15-2022 2:32 PM
Pull request updated for week2
06-23-2022 10:19 AM - edited 06-23-2022 10:20 AM
Updated for week 3... not sure where this thing is going. I hope to see some back & forth navigation testing for duplicate IDs 😉
06-14-2022 6:30 AM
06-14-2022 7:29 AM
Interesting idea with the todo list, let's see if you'll tick all the boxes 😉
06-21-2022 11:11 AM
Week 2 submitted
06-22-2022 1:25 PM
Week 3 Summited
06-15-2022 7:07 AM - edited 06-15-2022 7:08 AM
I wouldn't use control.firePress() to simulate a user click. Some controls expect parameters in the firePress internal UI5 method. Why not using .click instead and let UI5 fill these parameters ?
06-15-2022 7:18 AM
I agree.
06-27-2022 2:06 AM
Hi @ArnaudBuchholz, good idea, thanks for the suggestion. There is also a press() method provided by wdi5 that calls click() under the hood so you can use it on combination with wdi5 selectors (see wdi5 documentation). I will keep this in mind for future projects 🤙
06-17-2022 5:37 AM
06-22-2022 2:15 PM
Week 2 and 3 submitted
https://github.com/SAP-samples/sap-community-code-challenge-ui5/pull/34
06-24-2022 5:07 AM
06-28-2022 10:44 PM
Week 1,2,3 https://github.com/SAP-samples/sap-community-code-challenge-ui5/pull/40
I have idea for the next challenge. It is a Typescript in Sapui5. Maybe it will be interesting for me and some community members(I think)
06-29-2022 12:29 AM
Hi @askarpov1, definitely a great idea. More content on TypeScript in UI5 will come in the future 🤙
06-29-2022 4:07 AM
https://github.com/SAP-samples/sap-community-code-challenge-ui5/pull/46
Hi, week 1+2+3+4 🙂
06-29-2022 8:17 AM
It looks like week4 tests are "empty". In any case, they are passing without change on my PR.
06-30-2022 1:46 PM
That is correct. The task is to write your own tests (minimum 2) 😉
06-30-2022 1:12 PM
Week3 test "should have button that opens dialog" sometimes passes and sometimes fails. I use fragment and load the fragment asynchronously.
https://github.com/miyasuta/sap-community-code-challenge-ui5/tree/week3
06-30-2022 2:28 PM - edited 07-05-2022 1:45 PM
For week4 test, I'm writing the following code, but I sometimes get "navButton.firePress is not a function" error. Same again, sometimes pass, sometimes fail...
it("Should go back to main page", async () => {
const navButton = await browser.asControl({
selector: {
id: "navButton",
viewName: Detail._viewName
}
})
await navButton.firePress()
const url = await browser.getUrl()
expect(url).toMatch(/.*\/index.html#*$/)
})
My week4 code here.
https://github.com/miyasuta/sap-community-code-challenge-ui5/tree/week4
07-05-2022 11:17 PM
I have the same issues you've described. I had to add this "dummy" test with the browser title to give it some timeout: https://github.com/whydrae/sap-community-code-challenge-ui5/blob/main/webapp/test/e2e/week4.test.js#...
As I've seen in the browser, detail page doesn't have enough time to be opened. Looks like await Detail.open() doesn't actually wait until the page is fully rendered.
07-06-2022 8:14 AM - edited 07-06-2022 8:15 AM
Hi @iklopkov and @miyasuta,
I also observed something similar a while back (https://github.com/ui5-community/wdi5/issues/259). Can you maybe try and remove id="app" and see what happens? Would be interesting to see if this is the same issue.
07-06-2022 1:20 PM
Hi @nicoschoenteich ,
Thank you for your response. I have tried removing id="app" from App.view.xml, but as my Main view is embedded into App view, this broke navigation and the page is not properly displayed.
07-07-2022 2:56 AM
Of course it that brakes navigation... My bad.
07-06-2022 11:00 PM - edited 07-06-2022 11:01 PM
Hi @nicoschoenteich, I've tried that, but it also broke the app navigation.
I think I found what's wrong: should we add await here? https://github.com/SAP-samples/sap-community-code-challenge-ui5/blob/main/webapp/test/e2e/pageObject...
07-06-2022 1:41 PM
Hi @iklopkov,
Thank you for the solution provided. It worked for me, too.