Remote Code Analysis in ATC – How to check Smart F...

OlgaDolinskaja · ‎02-21-2019

This is the tenth blog of the blog series about Remote Code Analysis in ABAP Test Cockpit (ATC).

See also blogs:

Remote Code Analysis in ATC – One central check system for multiple systems on various releases.

Remote Code Analysis in ATC – Technical Setup step by step

Remote Code Analysis in ATC– Working with Baseline to suppress findings in old legacy code

Remote Code Analysis in ATC for Developers

Remote Code Analysis in ATC – Working with Exemptions

Remote Code Analysis in ATC – Scanning customer extensions

Remote Code Analysis in ATC – Working efficiently with ATC Result List

Remote Code Analysis in ATC – How to write an ATC check

Remote Code Analysis in ATC – Browse Central ATC Result in Developer Systems

Remote Code Analysis in ATC – Maintain exemptions approvers according to their responsibilities

Remote Code Analysis in ATC – FAQ

Motivation

You want to check your custom code Smart Forms and Adobe Forms with remote ATC. In this blog we will check a Smart Form and an Adobe Form for the SAP S/4HANA readiness for example.

Prerequisites

The central ATC check system SAP_BASIS >=7.52 must be set up and configured in your system landscape: see Remote Code Analysis in ATC – Technical Setup Step by Step.

For executing remote ATC checks from your development system use prerequisites from Remote Code Analysis in ATC for Developers.

For Smart Forms: in the remote checked systems implement the SAP Notes 2558283, 2613349.

For Adobe Forms: in the central ATC check system implement the SAP Note 2629856. In the remote checked systems implement the SAP Notes 2617401, 2613349 and 2617830.

Execute remote ATC check on your central system

In the ATC transaction just configure ATC check run series (click ATC Administration > Runs > Schedule Runs > Create (more on this in the Configuring Run Series in the Central System) over the package in your remote checked system, which contains your custom Smart Forms and/or Adobe Forms, which you want to check for SAP S/4HANA readiness:

Schedule the remote ATC run.

The SAP S/4HANA incompatibilities in the custom Adobe Form and Smart Form in the remote check system will be displayed in the ATC results and can be analyzed in detail:

Execute remote ATC check on your development system

If you are on your development system and want to check your custom Smart Forms and Adobe Forms objects for incompatibilities with SAP S/4HANA for example, you can run remote ATC checks in the ABAP Development Tools in Eclipse.

Just select the package containing your Smart Forms and/or Adobe Forms and use the context menu Run As -> ABAP Test Cockpit With… and specify the ATC check variant (e.g. S4HANA_READINESS_REMOTE).

The SAP S/4HANA incompatibilities in the custom Adobe Form and Smart Form will be displayed in the ATC results and you can analyze them.

former_member199125 · ‎05-28-2019

Hi Olga,

My Central ATC system is on sap basis 7.51 SP4. So can I apply these notes?

Thanks

Srinivas

OlgaDolinskaja · ‎05-28-2019

Hi Srinivas,

you need SAP_BASIS 7.52 (see "Prerequisites" chapter of the blog).

Regards,

Olga.

IanStubbings · ‎06-11-2019

Hi Olga

As smartforms are generated every time, there is no version management. Therefore, I assume there is no option of using the baseline with them?

Can you confirm?

Thanks

Ian

OlgaDolinskaja · ‎07-01-2019

Hi Ian,

there is no restriction for using baseline with Smartforms. Baseline has nothing to do with the version management. You can can change the code many times, and if it still looks the same after your changes, then the baseline remains valid. So if newly generated Smartforms have the same code, then they stay in the baseline.

Regards,

Olga.

muralikrishnanpv · ‎07-05-2019

Hi Olga,

In ATC check configuration screen, there is a checkbox called 'Calculate Quick Fix Proposals'. What exactly is the functionality of this checkbox?

I was expecting the ATC result set to suggest the possible errors which could be corrected using quick fix feature when I select this checkbox 🙂

Thanks,

Muralikrishnan

OlgaDolinskaja · ‎07-08-2019

Hi Muralikrishnan,

thank you for this remark. This checkbox is only relevant for the ATC runs in the context of the SAP Fiori App Custom Code Migration, since the App needs to calculate the Quick Fix filter in order to show, which ATC findings can be adjusted manually and which ATC findings can be adjusted by Quick Fixes. For all other use cases this checkbox should not be used. We will correct the SAP Help documentation regarding this.

Regards,

Olga.

former_member702797 · ‎12-01-2020

Hello All,

What is the benefit of "Calculate Quick Fix Proposals" in ATC. Is it related to Eclipse ADT Quick fix.?

Please suggest.

Thanks,

Sampat

OlgaDolinskaja · ‎12-01-2020

Hi Sampat,

please see my reply to Muralikrishnan above, it answers your question.

Regards,

Olga.

martin_reichenecker · ‎12-09-2020

Dear Olga,

does this also cover AIF interfaces (adobe interactive forms) from object type R3TR SFPI?
Since source code can be written in the initialization block, there could also be findings, that may cause problems when switching to the HANA DB (HANA code compliance) and/or to S/4HANA.

So far we have not found a way to scan the interfaces as well.
I am thankful for any advice.

Martin Reichenecker

former_member315451 · ‎12-10-2020

Hello Martin,

When you check an Adobe Form (SFPF Object) the corresponding Interface (SFPI) is checked. Technically speaking the corresponding generated Function Group /1BCDWB/SAPLSM00000xxx is checked. The generated function group include the custom code from “Initialization” and “FORM routines” blocks.

Best regards,

Mikhail

martin_reichenecker · ‎12-10-2020

Dear Mikhail, this helps a lot. Thank you!

OlgaDolinskaja · ‎12-14-2020

Hi Sampat,

just to let you know: we have updated the documentation and issued the correction SAP Note 3000103. You can implement it to make the checkbox “Calculate Quick Fix Proposals” in ATC invisible.

Regards,

Olga.

insungbang · ‎11-01-2023

Hello All,

Although ATC can check the smartforms(object type:SSFO), it can't check the customer smartform of which uses a deprecated Smartform Sytle(Object Type:SSST) because smartform doesn't have the where-used-list function for the style as a standard.

In this case, we can use an open source Z program in Basic Smart form “source” scan | SAP Blogs which displays the node information of smartforms based on XML information and we can see the style name by inputting the node name as an 'STDSTYLE' of corresponding Z-smartform lists.

Regards,

Insung

itmfru01 · ‎11-27-2023

Hi Olga,

what about SAPScript forms? Are the errors found as well, like:

SAPScript comparison MATNR

That should cause a warning?

Thank you in advance
Best regards
Norbert

OlgaDolinskaja · ‎11-27-2023

Hi Norbert,

there is an ATC check for SAP Script (under the "User Interface" category). See please the check documentation under the "i" button:

The 'SAP Script' Scanner analyses SAP Script content (SE61-documentation).

Following issues can be identified by the scanner:

Inconsistencies between transport key repository (TADIR) and document repository

Inactive document content

Inconsistent document content, like malformed tags

Invalid meta data, like missing master language

Kind regards,

Olga.

itmfru01 · ‎11-27-2023

Hi Olga,

thanks, I just tried it out.
Regarding to my example, nothing is found.

So S/4 (e.g. MATNR cut offs) findings are not related to these 4 categories and not checked, right?

Thanks & best regards
Norbert

OlgaDolinskaja · ‎11-27-2023

Hi Norbert,

yes, it looks like this.

Kind regards,

Olga.